feat: generic chain with sendAnywhere demo contract #9460

dckc · 2024-06-05T23:49:29Z

closes #9187

Description

DRAFT until

what to do about the way transfer() maps chainId to transferChannel?
clean up git history
update other facade callers
integrate more fully with well-known chains: hot-new-chain gets added and "Nothing breaks."
what to do with facade contract upgrade test, now that chainInfos is a caller thing?

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

cloudflare-workers-and-pages · 2024-06-05T23:51:46Z

Deploying agoric-sdk with Cloudflare Pages

Latest commit:	`8d90251`
Status:	✅ Deploy successful!
Preview URL:	https://c4c42129.agoric-sdk.pages.dev
Branch Preview URL:	https://dc-send-anywhere.agoric-sdk.pages.dev

View logs

turadg

nothing blocking; we'll keep iterating

turadg · 2024-06-06T21:24:41Z

packages/orchestration/src/exos/local-chain-account-kit.js

+          const agoricChainInfo = await chainHub.getChainInfo('agoric');
+          const { transferChannel } = await chainHub.getConnectionInfo(


given that these each do remote calls to the same vat, we should have a convinience for getting both

thought about it, but it's necessarily 2 round-trips: 1 to get the chainInfo, then you have to pick out the chainId and send it for the 2nd call

turadg · 2024-06-06T21:27:25Z

packages/orchestration/src/facade.js

  return {
    /** @returns {Promise<ChainInfo>} */
    async getChainInfo() {
      return mockLocalChainInfo;
    },

    async makeAccount() {
-      const account = await E(localchain).makeAccount();
+      const lowLevelAccountP = E(localchain).makeAccount();


naming by "level" is a smell.

makeLocalChainAccountKit is making something that does OrchestrationAccount and more. Let's rename it to LocalOrchestrationAccount like the RemoteOrchestrationAccount.

Up to you whether this PR. I'm happy to do it. If you want to land this as-is please at least leave a TODO comment.

turadg · 2024-06-06T21:30:30Z

packages/orchestration/src/facade.js

@@ -94,6 +99,8 @@ const makeLocalChainFacade = localchain => {
 };

 /**
+ * XXX should be provide...Facade


alternately keep this but also export provideOrchestrationFacade that ensures it runs at most once per zone.

provide isn't straightforward: maker return value {"orchestrate":"[Function orchestrate]"} is not storable

the stored parts would just be the kinds. The facade need not be memoized since it's stateless.

packages/orchestration/src/utils/chainHub.js

turadg · 2024-06-06T21:33:46Z

packages/orchestration/src/utils/chainHub.js

+export const makeChainHub = agoricNames => {
+  // XXX not reachably-durable? really?? take a zone arg?


Seems reasonable and cheap to allow the caller to choose

Suggested change

export const makeChainHub = agoricNames => {

// XXX not reachably-durable? really?? take a zone arg?

export const makeChainHub = (agoricNames, zone = makeHeapZone()) => {

we can iterate on what the best way to use it is. it might differ from contract to contract.

packages/orchestration/src/examples/sendAnywhere.contract.js

turadg · 2024-06-06T21:55:14Z

packages/orchestration/src/examples/sendAnywhere.contract.js

+
+      const info = await chain.getChainInfo();
+      const { chainId } = info;
+      await E(contractAccount).deposit(await pmtP, amt);


should theis be pipelined?

I really don't know what's allowed within an async flow

(and you point out, contractAccount is not remote itself)

turadg · 2024-06-06T21:58:09Z

packages/orchestration/src/examples/sendAnywhere.contract.js

+    async (orch, { zcf }, seat, offerArgs) => {
+      mustMatch(
+        offerArgs,
+        harden({ chainKey: M.scalar(), destAddr: M.string() }),


consider a more explicit name for chainKey to distinguish from chainName and chainId (both keys)

going with chainName in anticipation of supporting well-known chains too

packages/orchestration/src/utils/chainHub.js

dckc · 2024-06-07T22:06:03Z

packages/orchestration/src/utils/time.js

+      const [currentTime, timerBrand] = await Promise.all([
+        E(timer).getCurrentTimestamp(),
+        brandCache || E(timer).getTimerBrand(),
+      ]);
      const timeout =


@0xpatrickdev I managed to avoid passing timerBrand to every orchestration contract.

dckc · 2024-06-07T22:11:50Z

packages/orchestration/test/facade.test.ts

@@ -42,6 +48,7 @@ test('chain info', async t => {
  t.deepEqual(await result.getChainInfo(), mockChainInfo);
 });

+// XXX what to do with this test now that chainInfos is the caller's responsibility?


@turadg what to do with this test now that chainInfos is the caller's responsibility?

hmm yeah, the main point of it was the name registry behavior..

My first thought it so leave it around as a stub for other "contract upgrade" assertions, but if someone shows up to the test as-is they're going to be confused why it exists. So I think it best be removed.

I pruned it to a test.todo()

- update CosmosChainInfoShape to match type: stakingTokens is optional

dckc · 2024-06-10T14:09:35Z

@turadg updating the other callers to makeOrchestrationFacade (2165de7) is beyond what I think we discussed when you approved this. Take another look, please?

turadg · 2024-06-10T14:39:49Z

packages/orchestration/src/chain-info.js

-
-  await Promise.all(registrationPromises);
+  for await (const [name, info] of Object.entries(wellKnownChainInfo)) {
+    log(`registering chain ${name}`);


in #9477 I found it helpful to be a little more specific since this log output doesn't have any context qualifier:

Suggested change

log(`registering chain ${name}`);

log(`registering agoricName chain.${name}`);

Though now that there's a registerChain method the logging could go there.

turadg · 2024-06-10T14:46:51Z

packages/orchestration/src/facade.js

@@ -94,6 +99,8 @@ const makeLocalChainFacade = localchain => {
 };

 /**
+ * XXX should be provide...Facade


the stored parts would just be the kinds. The facade need not be memoized since it's stateless.

turadg · 2024-06-10T14:48:31Z

packages/orchestration/test/exos/local-chain-account-kit.test.ts

-import { wellKnownChainInfo } from '../../src/chain-info.js';
-
-const agoricChainInfo = wellKnownChainInfo.agoric;
+import { commonSetup } from '../supports.js';


turadg · 2024-06-10T14:50:05Z

packages/orchestration/test/supports.ts

@@ -38,8 +33,11 @@ export const commonSetup = async t => {
  // To test durability in unit tests, test a particular entity with `relaxDurabilityRules: false`.
  // To test durability integrating multiple vats, use a RunUtils/bootstrap test.
  const rootZone = makeHeapZone();
-  const bld = withAmountUtils(makeIssuerKit('BLD'));
-  const ist = withAmountUtils(makeIssuerKit('IST'));
+  const { mint: _b, ...bld } = withAmountUtils(makeIssuerKit('BLD'));


this could use some explaining. a perhaps more legible approach would be an option to withAmountUtils

The concern seems specific to pourPayment and makeFakeBankManagerKit so explaining here seems like the way to go.

Fair. If we have to do this a lot we might want an AmountUtils for runutils tests which takes pourPayment and abstracts it.

Something to consider in the course of designing the API for writing tests that work in multiple levels of integration. (Unit, swingset, chain)

- add IST to vbankAsset - inspectLocalBridge

dckc requested review from turadg and 0xpatrickdev June 5, 2024 23:49

dckc force-pushed the dc-send-anywhere branch 2 times, most recently from f7e2e2a to ab38074 Compare June 6, 2024 20:28

dckc changed the base branch from master to 9063-agoricInfo June 6, 2024 20:29

Base automatically changed from 9063-agoricInfo to master June 6, 2024 21:27

turadg approved these changes Jun 6, 2024

View reviewed changes

turadg reviewed Jun 6, 2024

View reviewed changes

packages/orchestration/src/utils/chainHub.js Outdated Show resolved Hide resolved

dckc force-pushed the dc-send-anywhere branch 3 times, most recently from 55aea8d to 995a831 Compare June 7, 2024 22:01

dckc commented Jun 7, 2024

View reviewed changes

dckc force-pushed the dc-send-anywhere branch from 995a831 to 711c109 Compare June 7, 2024 22:10

dckc commented Jun 7, 2024

View reviewed changes

dckc force-pushed the dc-send-anywhere branch 2 times, most recently from 2f9963d to 0431291 Compare June 8, 2024 01:08

dckc requested a review from turadg June 8, 2024 01:09

dckc force-pushed the dc-send-anywhere branch from 0431291 to c8be11c Compare June 8, 2024 06:56

dckc added 3 commits June 10, 2024 09:04

chore: IBCConnectionInfoShape typeGuard

f89659b

- update CosmosChainInfoShape to match type: stakingTokens is optional

chore: deposit() guard was missing optional pattern

34e87c0

feat: chainHub

78fbc6d

dckc force-pushed the dc-send-anywhere branch from 27d0480 to e83dd09 Compare June 10, 2024 14:05

dckc marked this pull request as ready for review June 10, 2024 14:05

dckc changed the title ~~feat: generic chain with sendAnywhere demo contract (WIP)~~ feat: generic chain with sendAnywhere demo contract Jun 10, 2024

turadg approved these changes Jun 10, 2024

View reviewed changes

dckc added the automerge:rebase Automatically rebase updates, then merge label Jun 10, 2024

dckc added 2 commits June 10, 2024 15:44

chore(local-chain-account-kit): use chainHub

98be3ab

chore(facade): move registerChain to chainHub

3a5a16a

dckc added 5 commits June 10, 2024 15:44

chore: get timer brand from service on-demand

aa328a2

chore: use chainHub in orch example contracts

81e3c99

chore(local-chain-account-kit): TimerService is Remote<>

376956e

test(orch supports): for sendAnywhere

71a3f7c

- add IST to vbankAsset - inspectLocalBridge

feat: sendAnywhere contract, test

8d90251

dckc force-pushed the dc-send-anywhere branch from 861c06a to 8d90251 Compare June 10, 2024 15:44

mergify bot merged commit 96c19f5 into master Jun 10, 2024
63 checks passed

mergify bot deleted the dc-send-anywhere branch June 10, 2024 16:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: generic chain with sendAnywhere demo contract #9460

feat: generic chain with sendAnywhere demo contract #9460

dckc commented Jun 5, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 5, 2024 •

edited

Loading

turadg left a comment

turadg Jun 6, 2024

dckc Jun 7, 2024

turadg Jun 6, 2024

turadg Jun 6, 2024

dckc Jun 7, 2024

turadg Jun 10, 2024

turadg Jun 6, 2024

turadg Jun 6, 2024

turadg Jun 6, 2024

dckc Jun 7, 2024

dckc Jun 7, 2024

dckc Jun 7, 2024

turadg Jun 8, 2024

dckc Jun 10, 2024

dckc commented Jun 10, 2024

turadg Jun 10, 2024

turadg Jun 10, 2024

turadg Jun 10, 2024

turadg Jun 10, 2024

dckc Jun 10, 2024

turadg Jun 10, 2024

		const agoricChainInfo = await chainHub.getChainInfo('agoric');
		const { transferChannel } = await chainHub.getConnectionInfo(

		export const makeChainHub = agoricNames => {
		// XXX not reachably-durable? really?? take a zone arg?

	export const makeChainHub = agoricNames => {
	// XXX not reachably-durable? really?? take a zone arg?
	export const makeChainHub = (agoricNames, zone = makeHeapZone()) => {

	log(`registering chain ${name}`);
	log(`registering agoricName chain.${name}`);

feat: generic chain with sendAnywhere demo contract #9460

feat: generic chain with sendAnywhere demo contract #9460

Conversation

dckc commented Jun 5, 2024 • edited Loading

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

cloudflare-workers-and-pages bot commented Jun 5, 2024 • edited Loading

Deploying agoric-sdk with Cloudflare Pages

turadg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dckc commented Jun 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dckc commented Jun 5, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 5, 2024 •

edited

Loading